-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-10777] Add two blog posts detailing changes to the type hints module of the Python SDK #12657
Merged
udim
merged 6 commits into
apache:master
from
saavan-google:BEAM-10777-add-python-type-hint-blog-posts
Aug 25, 2020
Merged
[BEAM-10777] Add two blog posts detailing changes to the type hints module of the Python SDK #12657
udim
merged 6 commits into
apache:master
from
saavan-google:BEAM-10777-add-python-type-hint-blog-posts
Aug 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run Website_Stage_GCS PreCommit |
udim
requested changes
Aug 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I had a few comments.
There's a new whitespace check that's failing. :(
website/www/site/content/en/blog/python-improved-annotations.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/python-improved-annotations.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/python-improved-annotations.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/python-performance-runtime-type-checking.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/python-performance-runtime-type-checking.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/python-performance-runtime-type-checking.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/python-performance-runtime-type-checking.md
Outdated
Show resolved
Hide resolved
Thanks, pushed some changes. PTAL when you have the chance |
udim
approved these changes
Aug 25, 2020
TobKed
pushed a commit
to damgadbot/beam
that referenced
this pull request
Aug 27, 2020
…odule of the Python SDK (apache#12657) * Add myself to authors * Add blog post #1: improved annotation support * Add draft of blog post #2: performance runtime type checking * Finish blog post #2 * Remove white space * Resolve PR comments Co-authored-by: Saavan Nanavati <saavan.nanavati@utexas.edu>
ibzib
pushed a commit
to ibzib/beam
that referenced
this pull request
Sep 30, 2020
…odule of the Python SDK (apache#12657) * Add myself to authors * Add blog post apache#1: improved annotation support * Add draft of blog post apache#2: performance runtime type checking * Finish blog post apache#2 * Remove white space * Resolve PR comments Co-authored-by: Saavan Nanavati <saavan.nanavati@utexas.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.