Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-725] Migrate to use the generic Google credentials library #1294

Closed
wants to merge 1 commit into from

Conversation

lukecwik
Copy link
Member

@lukecwik lukecwik commented Nov 7, 2016

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

Generic library has Apiary and gRPC library support instead of the Apiary only credentials we are currently using.

Dependency diff for modified pom files (old = left, new = right):
beam-sdks-java-core:

8d7
< [INFO] |  \- com.google.auth:google-auth-library-credentials:jar:0.4.0:compile
26c25,26
< [INFO] +- com.google.auth:google-auth-library-oauth2-http:jar:0.4.0:compile

---
> [INFO] +- com.google.auth:google-auth-library-credentials:jar:0.6.0:compile
> [INFO] +- com.google.auth:google-auth-library-oauth2-http:jar:0.6.0:compile
49d48
< [INFO] +- com.google.oauth-client:google-oauth-client-java6:jar:1.22.0:compile
53c52,53
< [INFO] |  \- com.google.api-client:google-api-client-jackson2:jar:1.22.0:compile

---
> [INFO] |  +- com.google.api-client:google-api-client-jackson2:jar:1.22.0:compile
> [INFO] |  \- com.google.oauth-client:google-oauth-client-java6:jar:1.22.0:compile

beam-runners-google-cloud-dataflow-java:

9d8
< [INFO] |  |  \- com.google.auth:google-auth-library-credentials:jar:0.4.0:compile
26d24
< [INFO] |  +- com.google.auth:google-auth-library-oauth2-http:jar:0.4.0:compile
41c39
< [INFO] |  +- com.google.oauth-client:google-oauth-client-java6:jar:1.22.0:compile

---
> [INFO] |  +- com.google.oauth-client:google-oauth-client:jar:1.22.0:compile
52d49
< [INFO] +- com.google.oauth-client:google-oauth-client:jar:1.22.0:compile
61a59,60
> [INFO] +- com.google.auth:google-auth-library-credentials:jar:0.6.0:compile
> [INFO] +- com.google.auth:google-auth-library-oauth2-http:jar:0.6.0:compile
64c63,64
< [INFO] |  \- com.google.api-client:google-api-client-jackson2:jar:1.22.0:compile

---
> [INFO] |  +- com.google.api-client:google-api-client-jackson2:jar:1.22.0:compile
> [INFO] |  \- com.google.oauth-client:google-oauth-client-java6:jar:1.22.0:compile

beam-sdks-java-io-google-cloud-platform:

20d19
< [INFO] |  +- com.google.auth:google-auth-library-oauth2-http:jar:0.4.0:compile
33c32
< [INFO] |  +- com.google.oauth-client:google-oauth-client-java6:jar:1.22.0:compile

---
> [INFO] |  +- com.google.oauth-client:google-oauth-client:jar:1.22.0:compile
44c43,44
< [INFO] |  \- com.google.api-client:google-api-client-jackson2:jar:1.22.0:compile

---
> [INFO] |  +- com.google.api-client:google-api-client-jackson2:jar:1.22.0:compile
> [INFO] |  \- com.google.oauth-client:google-oauth-client-java6:jar:1.22.0:compile
57d56
< [INFO] |  +- com.google.auth:google-auth-library-credentials:jar:0.4.0:compile
69c68,69
< [INFO] +- com.google.oauth-client:google-oauth-client:jar:1.22.0:compile

---
> [INFO] +- com.google.auth:google-auth-library-credentials:jar:0.6.0:compile
> [INFO] +- com.google.auth:google-auth-library-oauth2-http:jar:0.6.0:compile

…with Apiary and gRPC instead of the Apiary only credentials library.
@lukecwik
Copy link
Member Author

lukecwik commented Nov 7, 2016

R: @tgroh

Copy link
Member

@tgroh tgroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants