[BEAM-12071] Don't re-use WriteToPandasSink instances across windows #14374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennknowles
reviewed
Mar 30, 2021
| @@ -521,7 +521,7 @@ def expand(self, pcoll): | |||
| return pcoll | fileio.WriteToFiles( | |||
| path=dir, | |||
| file_naming=fileio.default_file_naming(name), | |||
| sink=_WriteToPandasFileSink( | |||
| sink=lambda _: _WriteToPandasFileSink( | |||
There was a problem hiding this comment.
Based on the ease of making this mistake, is the WriteToFiles API a hazard to other contributors and users?
There was a problem hiding this comment.
Yeah I think so. I'm not sure how to address it though. Should we detect and raise when this mode is used with non global windows? I'll file a jira for this.
TheNeuralBit
force-pushed
the
BEAM-12071
branch
from
dfecc04
to
e544f68
Compare
TheNeuralBit
force-pushed
the
BEAM-12071
branch
from
e544f68
to
b88ebc8
Compare
|
Run PythonDocker PreCommit |
kennknowles
approved these changes
Mar 30, 2021
kennknowles
approved these changes
Mar 30, 2021
| for path in glob.glob(pattern): | ||
| with open(path) as fin: | ||
| # TODO(Py3): yield from | ||
| for line in fin: | ||
| yield line.rstrip('\n') | ||
| if delete: |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks, good to know pytest has this. We've also used https://docs.python.org/3/library/tempfile.html elsewhere.
In this case I wanted to specifically delete files as we read them so I could confirm there are no other files (L344).
TheNeuralBit
added a commit
to TheNeuralBit/beam
that referenced
this pull request
Mar 31, 2021
…pache#14374) * Add (failing) windowed write test * Dont re-use pandas sink instances across windows
kennknowles
added a commit
that referenced
this pull request
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When given a concrete
FileSink,WriteToFileswill re-use the same sink across windows:beam/sdks/python/apache_beam/io/fileio.py
Line 461 in e92d184
beam/sdks/python/apache_beam/io/fileio.py
Line 625 in e92d184
This leads to all data (aside from one partition), being written to the file for a single window. The fix is to pass in a function that creates a new sink instead.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.