Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-11045] Avoid broken deps #14465

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Conversation

nika-qubit
Copy link
Contributor

@nika-qubit nika-qubit commented Apr 7, 2021

  1. Updated dependency jupyter-client from ">=6.1.11,<7" to ">=6.1.11,<6.1.13"
    as the newest version 6.1.13 contains a bug
    Release 6.1.13 nbconvert failing with TypeError: 'coroutine' object is not subscriptable jupyter/jupyter_client#637 that breaks notebooks
    when getting messages.
  2. This is caught by screen diff integration tests of interactive beam.
  3. Added a timeout=-1 to allow indefinite wait for execution of each
    notebook cell in integration tests. The default value was 1 second.
    Instead of timeout each cell, moved the timeout to each test using pytest mark.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK ULR Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status Build Status --- Build Status ---
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

1. A new release: jupyter-client 6.1.13 breaks notebooks when getting
   messages.
2. This is caught by screen diff integration tests of interactive beam.
3. The issue is documented at jupyter/jupyter_client#637
   ETA of the fix might be 6.2.x of jupyter-client.
4. Added a timeout=-1 to allow indefinite wait for execution of each
   notebook cell in integration tests. The default value was 1 second.
   Instead of timeout each cell, moved the timeout to each test using pytest mark.
@nika-qubit
Copy link
Contributor Author

R: @ajamato
PTAL, thx!

@ajamato
Copy link

ajamato commented Apr 7, 2021

Would you please update the PR description to be more clear.
i.e. "Update dependency to avoid dep version collision issue with X dependency"
"Update dependency X to Y, as prior version contained a Z bug"
of whatever is most appropriate

@ajamato
Copy link

ajamato commented Apr 7, 2021

LGTM otherwise

@nika-qubit
Copy link
Contributor Author

Would you please update the PR description to be more clear.
i.e. "Update dependency to avoid dep version collision issue with X dependency"
"Update dependency X to Y, as prior version contained a Z bug"
of whatever is most appropriate

Updated.

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #14465 (31efffe) into master (b8ff868) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14465      +/-   ##
==========================================
- Coverage   83.50%   83.47%   -0.03%     
==========================================
  Files         463      450      -13     
  Lines       58930    58832      -98     
==========================================
- Hits        49207    49110      -97     
+ Misses       9723     9722       -1     
Impacted Files Coverage Δ
...am/testing/benchmarks/nexmark/models/field_name.py
...sdks/python/apache_beam/runners/direct/__init__.py
..._beam/testing/benchmarks/nexmark/queries/query7.py
...apache_beam/examples/complete/game/leader_board.py
...che_beam/portability/api/beam_expansion_api_pb2.py
...s/python/apache_beam/testing/datatype_inference.py
...am/examples/complete/juliaset/juliaset/juliaset.py
...d/srcs/sdks/python/apache_beam/io/concat_source.py
...ransforms/transforms_keyword_only_args_test_py3.py
...s/sdks/python/apache_beam/runners/worker/logger.py
... and 903 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0805b9b...31efffe. Read the comment docs.

@nika-qubit nika-qubit merged commit 33cd75f into apache:master Apr 7, 2021
@nika-qubit nika-qubit deleted the BEAM-11045 branch April 8, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants