-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-13647] Use role for Go worker binary. #16729
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16729 +/- ##
===========================================
+ Coverage 46.49% 74.67% +28.17%
===========================================
Files 202 654 +452
Lines 19940 82133 +62193
===========================================
+ Hits 9271 61331 +52060
- Misses 9679 19812 +10133
Partials 990 990
Continue to review full report at Codecov.
|
R: @ihji |
Run Go Flink ValidatesRunner |
Run Go Spark ValidatesRunner |
Run Go Samza ValidatesRunner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM. Just one minor comment.
Please fix codecov failure before merging it. |
Note: All this code is covered by the integration tests, otherwise it wouldn't work. Adding test coverage to boot.go would require a complete refactor out of the single main method. I'll see what I can do about the other code though, in particular the binary substitution. |
Added tests to the core changes in the graphx package. The other packages changes require various bits of file IO, without which, the SDK wouldn't function at all. They would need to be refactored a bit, or have specialized file-io based tests to validate them, which is a bit much for this change. |
Run Java PreCommit |
Move away from older version of Go Worker Binary, in favour of a dedicated RoleUrn.
Validated "old container" behavior manually against Spark and Dataflow, with the pipelines successfully executing with each.
Minor breaking change to the dataflow lib, unexporting the StageFile function, and also have it return the SHA256 hash for the binary. dataflowlib was never intended to be used outside of the dataflow runner code anyway.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner
compliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.