Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-13907] Improve coverage of textio package #16937

Merged
merged 4 commits into from
Mar 1, 2022

Conversation

damccorm
Copy link
Contributor

Improves the coverage of our textio package. There were a number of untested functions here and adding tests was pretty quick.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #16937 (f78b579) into master (2a45a5b) will increase coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16937      +/-   ##
==========================================
+ Coverage   73.00%   73.45%   +0.44%     
==========================================
  Files         658      660       +2     
  Lines       86706    86793      +87     
==========================================
+ Hits        63301    63753     +452     
+ Misses      22405    21986     -419     
- Partials     1000     1054      +54     
Flag Coverage Δ
go 47.35% <ø> (+1.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/util/errorx/guarded.go 100.00% <0.00%> (ø)
...s/go/pkg/beam/core/graph/window/trigger/trigger.go 59.09% <0.00%> (ø)
sdks/go/pkg/beam/io/textio/sdf.go 46.72% <0.00%> (+3.73%) ⬆️
sdks/go/pkg/beam/io/databaseio/database.go 24.24% <0.00%> (+21.96%) ⬆️
sdks/go/pkg/beam/core/runtime/exec/coder.go 56.93% <0.00%> (+26.60%) ⬆️
sdks/go/pkg/beam/util/gcsx/gcs.go 27.41% <0.00%> (+27.41%) ⬆️
sdks/go/pkg/beam/io/textio/textio.go 65.57% <0.00%> (+41.80%) ⬆️
sdks/go/pkg/beam/internal/errors/errors.go 87.50% <0.00%> (+42.70%) ⬆️
sdks/go/pkg/beam/runners/dataflow/dataflow.go 50.00% <0.00%> (+44.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a45a5b...f78b579. Read the comment docs.

@damccorm
Copy link
Contributor Author

R: @jrmccluskey @riteshghorse

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod the two nits I added.

sdks/go/pkg/beam/io/textio/textio_test.go Outdated Show resolved Hide resolved
sdks/go/pkg/beam/io/textio/textio_test.go Outdated Show resolved Hide resolved
@damccorm
Copy link
Contributor Author

R: @lostluck

sdks/go/pkg/beam/io/textio/textio_test.go Outdated Show resolved Hide resolved
sdks/go/pkg/beam/io/textio/textio_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to wait for the tests to pass after my import removal.

@lostluck lostluck merged commit 6b06cbb into apache:master Mar 1, 2022
@damccorm damccorm deleted the users/damccorm/textio-coverage branch March 1, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants