Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generated dataflow apitools messages. #17039

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

robertwb
Copy link
Contributor

@robertwb robertwb commented Mar 8, 2022

Also add instructions for doing the generation and opt-out for apache rat.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@chamikaramj
Copy link
Contributor

LGTM. Thanks.

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #17039 (c80b1ba) into master (9833b7b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17039      +/-   ##
==========================================
- Coverage   73.82%   73.81%   -0.02%     
==========================================
  Files         667      667              
  Lines       87392    87302      -90     
==========================================
- Hits        64521    64445      -76     
+ Misses      21768    21754      -14     
  Partials     1103     1103              
Flag Coverage Δ
python 83.64% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../internal/clients/dataflow/dataflow_v1b3_client.py 71.52% <100.00%> (+0.26%) ⬆️
...nternal/clients/dataflow/dataflow_v1b3_messages.py 100.00% <100.00%> (ø)
sdks/python/apache_beam/io/localfilesystem.py 91.47% <0.00%> (-0.78%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.51% <0.00%> (-0.13%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 97.01% <0.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9833b7b...c80b1ba. Read the comment docs.

@robertwb robertwb merged commit f0e14fb into apache:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants