Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14071] Enabling Flink on Dataproc for Interactive Beam #17044

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

victorplusc
Copy link
Contributor

@victorplusc victorplusc commented Mar 8, 2022


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the python label Mar 8, 2022
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #17044 (b6ccca7) into master (bdc3162) will increase coverage by 0.16%.
The diff coverage is 35.92%.

❗ Current head b6ccca7 differs from pull request most recent head 9ccaa12. Consider uploading reports for the commit 9ccaa12 to get more accurate results

@@            Coverage Diff             @@
##           master   #17044      +/-   ##
==========================================
+ Coverage   73.79%   73.96%   +0.16%     
==========================================
  Files         663      671       +8     
  Lines       87056    88232    +1176     
==========================================
+ Hits        64243    65259    +1016     
- Misses      21729    21861     +132     
- Partials     1084     1112      +28     
Flag Coverage Δ
python 83.64% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/graph/window/windows.go 82.60% <ø> (ø)
sdks/go/pkg/beam/core/runtime/exec/util.go 74.28% <ø> (ø)
sdks/go/pkg/beam/core/runtime/harness/harness.go 11.26% <0.00%> (-1.43%) ⬇️
sdks/go/pkg/beam/core/util/reflectx/tags.go 0.00% <ø> (ø)
sdks/go/pkg/beam/forward.go 40.00% <ø> (ø)
sdks/go/pkg/beam/runners/direct/buffer.go 77.46% <ø> (ø)
sdks/go/pkg/beam/util/gcsx/gcs.go 27.41% <ø> (ø)
sdks/go/pkg/beam/core/runtime/exec/plan.go 48.61% <22.22%> (-8.80%) ⬇️
sdks/go/pkg/beam/core/runtime/exec/pardo.go 50.45% <25.00%> (ø)
...kg/beam/core/runtime/xlangx/expansionx/download.go 61.53% <61.53%> (+1.16%) ⬆️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdc3162...9ccaa12. Read the comment docs.

@victorplusc
Copy link
Contributor Author

R: @KevinGG
R: @rohdesamuel

Copy link
Contributor

@nika-qubit nika-qubit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nits.

@victorplusc victorplusc force-pushed the enable_flink_on_dataproc branch 3 times, most recently from f8251f2 to 10d999f Compare March 16, 2022 20:20
@victorplusc victorplusc force-pushed the enable_flink_on_dataproc branch 3 times, most recently from f2c3d62 to 477c980 Compare March 17, 2022 17:27
Copy link
Contributor

@nika-qubit nika-qubit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit

@nika-qubit nika-qubit merged commit d352d60 into apache:master Mar 21, 2022
@victorplusc victorplusc deleted the enable_flink_on_dataproc branch March 21, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants