-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-14071] Enabling Flink on Dataproc for Interactive Beam #17044
[BEAM-14071] Enabling Flink on Dataproc for Interactive Beam #17044
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17044 +/- ##
==========================================
+ Coverage 73.79% 73.96% +0.16%
==========================================
Files 663 671 +8
Lines 87056 88232 +1176
==========================================
+ Hits 64243 65259 +1016
- Misses 21729 21861 +132
- Partials 1084 1112 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
R: @KevinGG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few nits.
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
Show resolved
Hide resolved
f8251f2
to
10d999f
Compare
f2c3d62
to
477c980
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a nit
sdks/python/apache_beam/runners/interactive/dataproc/dataproc_cluster_manager.py
Outdated
Show resolved
Hide resolved
b6ccca7
to
9ccaa12
Compare
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.