Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-14191] Convert URLs to local jars when constructing filesToStage #17199

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

chamikaramj
Copy link
Contributor

Convert URLs to local jars when constructing filesToStage


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@pabloem
Copy link
Member

pabloem commented Mar 29, 2022

LGTM thanks for looking into this, Cham!

@chamikaramj
Copy link
Contributor Author

Run Python 3.8 PostCommit

@chamikaramj
Copy link
Contributor Author

Run Python 3.8 PostCommit

@deepix
Copy link
Contributor

deepix commented Mar 29, 2022

@chamikaramj @pabloem Thanks a lot for the fix!

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #17199 (c353a96) into master (993061a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #17199   +/-   ##
=======================================
  Coverage   73.96%   73.96%           
=======================================
  Files         672      672           
  Lines       88259    88269   +10     
=======================================
+ Hits        65277    65288   +11     
+ Misses      21869    21868    -1     
  Partials     1113     1113           
Flag Coverage Δ
python 83.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/transforms/external.py 80.00% <100.00%> (+0.27%) ⬆️
sdks/python/apache_beam/internal/gcp/auth.py 81.03% <0.00%> (-0.45%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.51% <0.00%> (-0.13%) ⬇️
setup.py 0.00% <0.00%> (ø)
sdks/python/apache_beam/transforms/util.py 95.96% <0.00%> (ø)
...on/apache_beam/runners/dataflow/dataflow_runner.py 82.36% <0.00%> (ø)
...am/testing/benchmarks/chicago_taxi/trainer/task.py 0.00% <0.00%> (ø)
...m/testing/benchmarks/chicago_taxi/trainer/model.py 0.00% <0.00%> (ø)
sdks/python/apache_beam/typehints/decorators.py 92.73% <0.00%> (+0.06%) ⬆️
sdks/python/apache_beam/runners/runner.py 74.23% <0.00%> (+0.15%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 993061a...c353a96. Read the comment docs.

@chamikaramj
Copy link
Contributor Author

Run Python 3.8 PostCommit

@chamikaramj
Copy link
Contributor Author

Run XVR_PythonUsingJava_Dataflow PostCommit

@chamikaramj chamikaramj merged commit dc5e209 into apache:master Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants