-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-14191] Convert URLs to local jars when constructing filesToStage #17199
Conversation
LGTM thanks for looking into this, Cham! |
Run Python 3.8 PostCommit |
9fe0146
to
7934be5
Compare
Run Python 3.8 PostCommit |
7934be5
to
ca12619
Compare
@chamikaramj @pabloem Thanks a lot for the fix! |
ca12619
to
c353a96
Compare
Codecov Report
@@ Coverage Diff @@
## master #17199 +/- ##
=======================================
Coverage 73.96% 73.96%
=======================================
Files 672 672
Lines 88259 88269 +10
=======================================
+ Hits 65277 65288 +11
+ Misses 21869 21868 -1
Partials 1113 1113
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Run Python 3.8 PostCommit |
Run XVR_PythonUsingJava_Dataflow PostCommit |
Convert URLs to local jars when constructing filesToStage
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.