Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google-cloud-bigquery-storage to require 2.11.0 or later #17686

Closed
wants to merge 1 commit into from

Conversation

kmjung
Copy link
Contributor

@kmjung kmjung commented May 16, 2022

This change updates the dependency requirements for the google-cloud-bigquery-storage library to require version 2.11 or later in order to pick up googleapis/python-bigquery-storage#366.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@asf-ci
Copy link

asf-ci commented May 16, 2022

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented May 16, 2022

Can one of the admins verify this patch?

Copy link
Contributor

@chamikaramj chamikaramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@chamikaramj
Copy link
Contributor

Run Python 3.8 PostCommit

@chamikaramj
Copy link
Contributor

Ah, actually you also need to run following.
./gradlew :sdks:python:container:generatePythonRequirementsAll

See: https://github.com/apache/beam/blob/master/sdks/python/container/py38/base_image_requirements.txt#L17

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #17686 (a1d51d4) into master (03c3c36) will increase coverage by 1.40%.
Report is 4078 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #17686      +/-   ##
==========================================
+ Coverage   74.00%   75.41%   +1.40%     
==========================================
  Files         695      702       +7     
  Lines       91798   100144    +8346     
==========================================
+ Hits        67939    75520    +7581     
- Misses      22611    23376     +765     
  Partials     1248     1248              
Flag Coverage Δ
python 84.56% <ø> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 87 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaltay
Copy link
Member

aaltay commented May 27, 2022

What is the next step on this PR?

@aaltay
Copy link
Member

aaltay commented Jun 9, 2022

Could this be merged?

@aaltay
Copy link
Member

aaltay commented Jun 9, 2022

Run Python PreCommit

@aaltay
Copy link
Member

aaltay commented Jun 18, 2022

It seems like tests are failing. I can trigger once again.

@github-actions
Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Jun 16, 2023
@github-actions
Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Aug 16, 2023
@github-actions
Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 16, 2023
@github-actions
Copy link
Contributor

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants