Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-1512] Optimize leaf transforms materialization #2046

Closed

Conversation

aviemzur
Copy link
Member

@aviemzur aviemzur commented Feb 19, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@aviemzur
Copy link
Member Author

R: @amitsela
Cc: @staslev

@aviemzur aviemzur force-pushed the optimize-leaf-materialization branch from 8449803 to 62644dc Compare February 19, 2017 17:55
@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.187% when pulling 62644dc on aviemzur:optimize-leaf-materialization into 4063019 on apache:master.

@asfbot
Copy link

asfbot commented Feb 19, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7590/
--none--

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 69.19% when pulling 62644dc on aviemzur:optimize-leaf-materialization into 4063019 on apache:master.

@asfbot
Copy link

asfbot commented Feb 19, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/7591/
--none--

@staslev
Copy link
Contributor

staslev commented Feb 19, 2017

That's quite elegant.

I guess the proof that it really works lies in the fact the tests have managed to pass but just out of curiosity, did you have a chance to give it a try in cluster mode?

@aviemzur
Copy link
Member Author

aviemzur commented Feb 19, 2017

@staslev Yeah, ran it on cluster as well. Looks good!

@amitsela
Copy link
Member

LGTM, merging.

@asfgit asfgit closed this in 4e5a762 Feb 20, 2017
@aviemzur aviemzur deleted the optimize-leaf-materialization branch March 11, 2017 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants