New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable close issue as not planned #22032

Merged

damccorm merged 4 commits into apache:master from Abacn:closeIssueNotPlanned

Jun 24, 2022

Contributor

Abacn commented Jun 23, 2022

Fixes #22031

Make use of state_reason attribute
Run on only issue comment and exclude pull request comment
Added documentation

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Choose reviewer(s) and mention them in a comment (R: @username).
Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.


          Enable close issue as not planned

239bde3

* Make use of state_reason attribute

* Run on only issue comment and exclude pull request comment

* Added documentation

asf-ci commented Jun 23, 2022

Can one of the admins verify this patch?

4 similar comments

asf-ci commented Jun 23, 2022

Can one of the admins verify this patch?

asf-ci commented Jun 23, 2022

Can one of the admins verify this patch?

asf-ci commented Jun 23, 2022

Can one of the admins verify this patch?

asf-ci commented Jun 23, 2022

Can one of the admins verify this patch?

github-actions bot added the build label

Contributor Author

Abacn commented Jun 23, 2022 •

edited

Loading

Should we allow close issue for those only assigned to them? (Currently anyone can use close-issue phrase, and this does not change with this pr)

Contributor Author

Abacn commented Jun 23, 2022

Example: Abacn#39

Contributor Author

Abacn commented Jun 23, 2022

damccorm reviewed

View reviewed changes

.github/workflows/self-assign.yml Outdated Show resolved Hide resolved

Contributor

damccorm commented Jun 23, 2022

Should we allow close issue for those only assigned to them? (Currently anyone can use close-issue phrase, and this does not change with this pr)

I think yes for 2 reasons:

Kenn and I created a ton of issues on behalf of other people as part of the migration. Their owners need to be able to close
Anyone can self-assign anyways

Abacn added 2 commits

June 23, 2022 20:18


          apply suggested changes

61c8fd9


          only issue assignee triggers close issue

57bd4a3

Contributor Author

Abacn commented Jun 24, 2022

Changes applied.

damccorm reviewed

View reviewed changes

.github/workflows/self-assign.yml Outdated

Comment on lines 38 to 39

		ISSUE_ASSIGNEE="$(jq '.issue.assignee.login' $GITHUB_EVENT_PATH \| tr -d \")"
		if [[ $ISSUE_ASSIGNEE == $LOGIN && $BODY == "$INPUT_CLOSE" && $BODY != "\`$INPUT_CLOSE\`" ]]; then

Contributor

damccorm Jun 24, 2022

Suggested change

      
                    ISSUE_ASSIGNEE="$(jq '.issue.assignee.login' $GITHUB_EVENT_PATH | tr -d \")"
          
                    if [[ $ISSUE_ASSIGNEE == $LOGIN && $BODY == *"$INPUT_CLOSE"* && $BODY != *"\`$INPUT_CLOSE\`"* ]]; then
          
                    if [[ $BODY == *"$INPUT_CLOSE"* && $BODY != *"\`$INPUT_CLOSE\`"* ]]; then

I'm sorry, I misspoke (mistyped?) earlier, though my reasoning was still correct. I don't think we should restrict issue close to the assignee. Closing an issue as a non-assignee is probably fairly common (e.g. an owner of a migrated ticket needs to close it), and its not doing anything permissions-wise since anyone can self-assign. I can't think of a scenario where restricting like this helps us.

Contributor Author

Abacn Jun 24, 2022

Agree. adjusted


          remove .close-issue restriction

6fd9ef1

damccorm approved these changes

View reviewed changes

Contributor

damccorm left a comment

LGTM, thanks!

damccorm merged commit e7924d1 into apache:master

Abacn deleted the closeIssueNotPlanned branch

June 24, 2022 23:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels