Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make GCP OAuth scopes configurable via pipeline options." #23674

Closed
wants to merge 1 commit into from

Conversation

AnandInguva
Copy link
Contributor

Reverts #23644

@AnandInguva
Copy link
Contributor Author

Run Python 3.7 PostCommit

@AnandInguva
Copy link
Contributor Author

Run Python 3.9 PostCommit

@AnandInguva
Copy link
Contributor Author

Run Python 3.8 PostCommit

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #23674 (62ef2c1) into master (690f351) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master   #23674      +/-   ##
==========================================
- Coverage   73.33%   73.33%   -0.01%     
==========================================
  Files         719      719              
  Lines       95794    95795       +1     
==========================================
- Hits        70252    70248       -4     
- Misses      24231    24236       +5     
  Partials     1311     1311              
Flag Coverage Δ
python 83.04% <88.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/gcp/bigquery_tools.py 73.30% <ø> (-0.04%) ⬇️
...dks/python/apache_beam/options/pipeline_options.py 94.36% <ø> (-0.03%) ⬇️
...ks/python/apache_beam/runners/interactive/utils.py 95.06% <ø> (-0.03%) ⬇️
sdks/python/apache_beam/internal/gcp/auth.py 78.66% <88.88%> (-4.20%) ⬇️
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.50% <0.00%> (-1.27%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.42% <0.00%> (-0.13%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.24% <0.00%> (+0.16%) ⬆️
sdks/python/apache_beam/io/source_test_utils.py 89.40% <0.00%> (+1.38%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lukecwik
Copy link
Member

Note that I filed #23676 for the failure

@lukecwik
Copy link
Member

lukecwik commented Oct 17, 2022

I believe I have a forward fix in #23677, ran locally and also confirming with postcommit that issue is resolved.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @pabloem for label python.
R: @robertwb for label java.
R: @pabloem for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@lukecwik
Copy link
Member

#23677 resolved the problem

@lukecwik lukecwik closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants