Speed up check on website links #23737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r @damccorm - this should also let us skip files that are very large to speed up the checks |
damccorm
reviewed
Oct 19, 2022
website/www/check-links.sh
Outdated
| @@ -73,7 +73,7 @@ for external_link in "${external_links[@]}" | |||
| do | |||
| redraw_progress_bar 50 1 $i ${#external_links[@]} | |||
|
|
|||
| if ! curl -sSfL --max-time 10 --connect-timeout 10 --retry 2 -4 "${external_link}" > /dev/null ; then | |||
| if ! curl -sSfL --max-filesize 2000000 --max-time 10 --connect-timeout 10 --retry 2 -4 "${external_link}" > /dev/null ; then | |||
There was a problem hiding this comment.
What happens for files greater than this size? If the answer is just, they don't get downloaded, can we set this even lower?
There was a problem hiding this comment.
correct. curl errors out in that scenario, which causes the files to be added to the list of troublemakers - but I think this may be fine. I can add some printed output and comments stating this.
pabloem
force-pushed
the
speedup-check
branch
from
9f4aea6
to
2be11fb
Compare
damccorm
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.