Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for JsonSchema in Kafka Read Schema Transform #24272

Merged
merged 4 commits into from
Dec 5, 2022

Conversation

pabloem
Copy link
Member

@pabloem pabloem commented Nov 18, 2022

This PR depends on #24271


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @Abacn for label build.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #24272 (d15913b) into master (d15913b) will not change coverage.
The diff coverage is n/a.

❗ Current head d15913b differs from pull request most recent head 4344539. Consider uploading reports for the commit 4344539 to get more accurate results

@@           Coverage Diff           @@
##           master   #24272   +/-   ##
=======================================
  Coverage   73.38%   73.38%           
=======================================
  Files         719      719           
  Lines       97206    97206           
=======================================
  Hits        71335    71335           
  Misses      24524    24524           
  Partials     1347     1347           
Flag Coverage Δ
go 51.64% <0.00%> (ø)
python 83.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pabloem pabloem force-pushed the kafka-w-jsonschema branch 2 times, most recently from 67c2b34 to 30574bd Compare November 21, 2022 23:22
@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @kennknowles @Abacn @johnjcasey

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @lukecwik for label java.
R: @damccorm for label build.
R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@damccorm
Copy link
Contributor

damccorm commented Dec 2, 2022

stop reviewer notifications

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

Stopping reviewer notifications for this pull request: requested by reviewer

@pabloem
Copy link
Member Author

pabloem commented Dec 4, 2022

Run Java PreCommit

@pabloem
Copy link
Member Author

pabloem commented Dec 4, 2022

r: @ahmedabu98 : )

@pabloem
Copy link
Member Author

pabloem commented Dec 4, 2022

Run Java PreCommit

Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pablo! I appreciate the Class name changes :) LGTM

@pabloem pabloem merged commit dbb5849 into apache:master Dec 5, 2022
lostluck pushed a commit to lostluck/beam that referenced this pull request Dec 22, 2022
* Implement KafkaReadSchemaTransform support for JSON

* fixup

* add dependencies

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants