Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for PubSub Lite in Schema Transforms #24275

Merged
merged 3 commits into from
Dec 3, 2022

Conversation

pabloem
Copy link
Member

@pabloem pabloem commented Nov 19, 2022

This PR depends on #24271


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Merging #24275 (757569c) into master (2dbf94f) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 757569c differs from pull request most recent head f655772. Consider uploading reports for the commit f655772 to get more accurate results

@@            Coverage Diff             @@
##           master   #24275      +/-   ##
==========================================
- Coverage   73.37%   73.36%   -0.01%     
==========================================
  Files         719      718       -1     
  Lines       97206    97164      -42     
==========================================
- Hits        71323    71286      -37     
+ Misses      24536    24530       -6     
- Partials     1347     1348       +1     
Flag Coverage Δ
python 82.99% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/metrics/dumper.go 49.20% <0.00%> (-4.77%) ⬇️
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
sdks/go/pkg/beam/io/bigqueryio/bigquery.go 5.74% <0.00%> (-4.15%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.50% <0.00%> (-1.27%) ⬇️
sdks/python/apache_beam/io/aws/s3io.py 84.42% <0.00%> (-0.42%) ⬇️
sdks/python/apache_beam/io/gcp/gcsio.py 92.12% <0.00%> (-0.16%) ⬇️
sdks/python/apache_beam/io/azure/blobstorageio.py 27.01% <0.00%> (-0.14%) ⬇️
sdks/python/apache_beam/runners/render.py 49.45% <0.00%> (ø)
sdks/go/pkg/beam/core/runtime/exec/window.go 55.00% <0.00%> (ø)
...examples/inference/pytorch_image_classification.py 0.00% <0.00%> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @Abacn for label build.
R: @ahmedabu98 for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@pabloem pabloem force-pushed the pslite-schematransform branch 2 times, most recently from f10225e to f172553 Compare November 21, 2022 23:22
@ahmedabu98
Copy link
Contributor

LGTM from schema transform side of things

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @robertwb @Abacn @ahmedabu98

@github-actions github-actions bot added build and removed build labels Dec 2, 2022
@github-actions github-actions bot added build and removed build labels Dec 2, 2022
@pabloem pabloem merged commit 4fd2fad into apache:master Dec 3, 2022
@pabloem pabloem deleted the pslite-schematransform branch December 3, 2022 19:41
prodriguezdefino pushed a commit to prodriguezdefino/beam-pabs that referenced this pull request Dec 6, 2022
* Implement PubsubLiteReadSchemaTransform

* fixup

* fixup
lostluck pushed a commit to lostluck/beam that referenced this pull request Dec 22, 2022
* Implement PubsubLiteReadSchemaTransform

* fixup

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants