Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go SDK] Lint fixes #24455

Merged
merged 1 commit into from
Dec 1, 2022
Merged

[Go SDK] Lint fixes #24455

merged 1 commit into from
Dec 1, 2022

Conversation

riteshghorse
Copy link
Contributor

Go lint fixes introduced in #24307


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the go label Dec 1, 2022
@riteshghorse
Copy link
Contributor Author

Run Go PostCommit

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #24455 (b803b42) into master (57e5b69) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #24455      +/-   ##
==========================================
- Coverage   73.36%   73.36%   -0.01%     
==========================================
  Files         718      718              
  Lines       97165    97165              
==========================================
- Hits        71287    71284       -3     
- Misses      24531    24533       +2     
- Partials     1347     1348       +1     
Flag Coverage Δ
go 51.58% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/core/runtime/exec/window.go 55.00% <ø> (ø)
sdks/go/pkg/beam/core/metrics/dumper.go 49.20% <0.00%> (-4.77%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@riteshghorse
Copy link
Contributor Author

R: @lostluck

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@riteshghorse riteshghorse merged commit 263a7d8 into apache:master Dec 1, 2022
@riteshghorse riteshghorse deleted the lints branch December 1, 2022 15:15
prodriguezdefino pushed a commit to prodriguezdefino/beam-pabs that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants