-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-2.44.0] Cherry-pick: Revert 23969 sqlttypes #24492
[release-2.44.0] Cherry-pick: Revert 23969 sqlttypes #24492
Conversation
…ils (apache#23969)" This reverts commit d5d76b9.
R: @kennknowles |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
LGTM and I will merge once it is green. |
Run Java PreCommit |
changes on sdk.core often makes the first run of precommit timeout as gradle cache is not used and it tries to re-compile all codes. |
Tests actually ended. Java Precommit fail |
Just a reminder (don't want this PR to block the release) @kennknowles |
run java precommit |
it was a pulsar flake, but I have time to kick it again to get green |
|
Run Java PreCommit |
This time is |
OK I am going to merge anyhow. That test is disabled on master now. |
Fixes #24415
Please add a meaningful description for your change here
Cherry pick #24489 into release-2.44.0 branch.
Justification: #23969 introduced a regression in 2.44.0. It introduces SqlType.TIMESTAMP (micros_instant) logical type when converting from avro logical type TimestampMicros, but this Beam portable logical type is not yet supported in Beam SQL. Similar regression may occur other than Beam SQL where micros_instant is not supported.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.