Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix POM of beam-sdks-java-core #24760

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Conversation

mosche
Copy link
Member

@mosche mosche commented Dec 22, 2022

As of #24271 the pom of beam-sdks-java-core is broken. There's no version specified for org.json:json in BeamModulePlugin:

[WARNING] The POM for org.apache.beam:beam-sdks-java-core:jar:2.45.0-20221214.234815-14 is invalid, transitive dependencies (if any) will not be available: 1 problem was encountered while building the effective model for org.apache.beam:beam-sdks-java-core:2.45.0-SNAPSHOT
[ERROR] 'dependencies.dependency.version' for org.json:json:jar is missing. @

This sets the version to the transitive version resolved through com.github.erosb:everit-json-schema:1.14.1.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the build label Dec 22, 2022
@mosche
Copy link
Member Author

mosche commented Dec 22, 2022

R: @pabloem
cc @aromanenko-dev

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@aromanenko-dev
Copy link
Contributor

Run GoPortable PreCommit

@aromanenko-dev
Copy link
Contributor

Run Java_Pulsar_IO_Direct PreCommit

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #24760 (46c7778) into master (b877a66) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #24760   +/-   ##
=======================================
  Coverage   73.34%   73.34%           
=======================================
  Files         721      721           
  Lines       97224    97224           
=======================================
+ Hits        71306    71310    +4     
+ Misses      24568    24564    -4     
  Partials     1350     1350           
Flag Coverage Δ
python 82.99% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.24% <0.00%> (+0.16%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 93.67% <0.00%> (+0.24%) ⬆️
sdks/python/apache_beam/utils/interactive_utils.py 97.56% <0.00%> (+2.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mosche
Copy link
Member Author

mosche commented Dec 22, 2022

Run Java_Pulsar_IO_Direct PreCommit

@mosche
Copy link
Member Author

mosche commented Dec 22, 2022

Run Java_Kafka_IO_Direct PreCommit

Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM
Just a quick question, ptal

@aromanenko-dev aromanenko-dev merged commit eb23b0a into apache:master Dec 22, 2022
@mosche mosche deleted the 24675_fix_core_pom branch January 3, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants