-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for loading torchscript models #25321
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25321 +/- ##
==========================================
- Coverage 72.93% 72.85% -0.09%
==========================================
Files 748 750 +2
Lines 99366 99484 +118
==========================================
+ Hits 72473 72476 +3
- Misses 25525 25640 +115
Partials 1368 1368
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run PythonLint PreCommit |
R: @damccorm |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll merge once checks pass
I think there are some lint issues(not clear why they appear). I will tackle them tomorrow and will ping you. |
@damccorm The tests pass but for some reason they are not updated in UI. PTAL |
Run Whitespace PreCommit |
LGTM pending checks passing |
Adding support for loading models that are saved in
torchscript
formatMore details at https://pytorch.org/tutorials/beginner/saving_loading_models.html#export-load-model-in-torchscript-format
This will enable the users to load the whole model without requiring model class.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.