Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#24789][prism] Tiny staticcheck fix #25546

Merged
merged 1 commit into from
Feb 17, 2023
Merged

[#24789][prism] Tiny staticcheck fix #25546

merged 1 commit into from
Feb 17, 2023

Conversation

lostluck
Copy link
Contributor

Fix accidental double import in prism/internal/jobservices/metrics_test.go

See #24789


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lostluck LGTM

@lostluck lostluck changed the title [##24789 ][prism] Tiny staticcheck fix [#24789][prism] Tiny staticcheck fix Feb 17, 2023
@lostluck
Copy link
Contributor Author

The action tests are going to fail until #25545 is merged, but these side fixes will make that run eventually go green. :)

@lostluck lostluck merged commit f358fcd into master Feb 17, 2023
@lostluck lostluck deleted the prism-fixstatic branch February 17, 2023 20:56
lostluck added a commit to lostluck/beam that referenced this pull request Feb 20, 2023
Co-authored-by: lostluck <13907733+lostluck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants