-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Replace more uses of ClassLoadingStrategy.Default.INJECTION
(#23210)"
#25566
Conversation
…apache#23210)" This reverts commit 2b62912.
Run SQL_Java17 PreCommit |
Run SQL_Java11 PreCommit |
ClassLoadingStrategy.Default.INJECTION
(#23210)"ClassLoadingStrategy.Default.INJECTION
(#23210)"
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Kafka_IO_Direct PreCommit known flake related to #25261; other tests not updated to GitHub UI are avtually succeeded. |
LGTM |
thanks @Abacn - indeed this looks like it's causing trouble : ) |
Run Java_Kafka_IO_Direct PreCommit |
I can reproduce with
I think most of the failures are related to this change from the original PR: #23210 (comment) |
Kafka_IO_Direct passed, merging for now |
…JECTION` (apache#23210)" (apache#25566)" This reverts commit b92600a.
…JECTION` (apache#23210)" (apache#25566)" This reverts commit b92600a.
…JECTION` (apache#23210)" (apache#25566)" This reverts commit b92600a.
…JECTION` (apache#23210)" (apache#25566)" This reverts commit b92600a.
…apache#23210)" (apache#25566) This reverts commit 2b62912.
…JECTION` (apache#23210)" (apache#25566)" This reverts commit b92600a.
…JECTION` (apache#23210)" (apache#25566)" This reverts commit b92600a.
…JECTION` (apache#23210)" (apache#25566)" This reverts commit b92600a.
Investigate Java11/17 postcommit test failures
This reverts commit 2b62912.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.