Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Replace more uses of ClassLoadingStrategy.Default.INJECTION (#23210)" #25566

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Feb 20, 2023

Investigate Java11/17 postcommit test failures

This reverts commit 2b62912.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the java label Feb 20, 2023
@Abacn
Copy link
Contributor Author

Abacn commented Feb 20, 2023

Run SQL_Java17 PreCommit

@Abacn
Copy link
Contributor Author

Abacn commented Feb 20, 2023

Run SQL_Java11 PreCommit

@Abacn
Copy link
Contributor Author

Abacn commented Feb 21, 2023

I am going to open this for now to get tests back green (and unblocks some other outstanding merging) CC: @cushon @lukecwik

@Abacn Abacn marked this pull request as ready for review February 21, 2023 15:23
@Abacn Abacn changed the title [Do not merge] Revert "Replace more uses of ClassLoadingStrategy.Default.INJECTION (#23210)" Revert "Replace more uses of ClassLoadingStrategy.Default.INJECTION (#23210)" Feb 21, 2023
@Abacn
Copy link
Contributor Author

Abacn commented Feb 21, 2023

R: @aromanenko-dev

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn
Copy link
Contributor Author

Abacn commented Feb 21, 2023

Kafka_IO_Direct PreCommit known flake related to #25261; other tests not updated to GitHub UI are avtually succeeded.

@lukecwik
Copy link
Member

LGTM

@pabloem
Copy link
Member

pabloem commented Feb 21, 2023

thanks @Abacn - indeed this looks like it's causing trouble : )

@pabloem
Copy link
Member

pabloem commented Feb 21, 2023

Run Java_Kafka_IO_Direct PreCommit

@cushon
Copy link
Contributor

cushon commented Feb 21, 2023

I can reproduce with

JAVA_HOME=$JAVA8_HOME ./gradlew -PdisableSpotlessCheck=true -PdisableCheckStyle=true -PcompileAndRunTestsWithJava17 -PskipCheckerFramework -Pjava17Home=$JAVA17_HOME --max-workers=8 -Dorg.gradle.jvmargs=-Xms2g -Dorg.gradle.jvmargs=-Xmx6g -Dorg.gradle.vfs.watch=false -Pdocker-pull-licenses clean  :sdks:java:extensions:sql:test
java.lang.IllegalArgumentException: org.apache.beam.sdk.coders.Coder$ByteBuddy$3j3EZPM9 must be defined in the same package as org.apache.beam.sdk.schemas.Schema
	at net.bytebuddy.dynamic.loading.ClassInjector$UsingLookup.injectRaw(ClassInjector.java:1635)
	at net.bytebuddy.dynamic.loading.ClassInjector$AbstractBase.inject(ClassInjector.java:118)
	at net.bytebuddy.dynamic.loading.ClassLoadingStrategy$UsingLookup.load(ClassLoadingStrategy.java:519)
	at net.bytebuddy.dynamic.TypeResolutionStrategy$Passive.initialize(TypeResolutionStrategy.java:101)
	at net.bytebuddy.dynamic.DynamicType$Default$Unloaded.load(DynamicType.java:6317)
	at org.apache.beam.sdk.coders.RowCoderGenerator.generate(RowCoderGenerator.java:176)
	at org.apache.beam.sdk.schemas.SchemaCoder.getDelegateCoder(SchemaCoder.java:117)

I think most of the failures are related to this change from the original PR: #23210 (comment)

@Abacn
Copy link
Contributor Author

Abacn commented Feb 21, 2023

Kafka_IO_Direct passed, merging for now

@Abacn Abacn merged commit b92600a into apache:master Feb 21, 2023
@Abacn Abacn deleted the checkjava11fail branch February 21, 2023 20:23
cushon added a commit to cushon/beam that referenced this pull request Feb 21, 2023
cushon added a commit to cushon/beam that referenced this pull request Feb 28, 2023
cushon added a commit to cushon/beam that referenced this pull request Feb 28, 2023
cushon added a commit to cushon/beam that referenced this pull request Mar 9, 2023
ruslan-ikhsan pushed a commit to akvelon/beam that referenced this pull request Mar 10, 2023
cushon added a commit to cushon/beam that referenced this pull request Apr 19, 2023
cushon added a commit to cushon/beam that referenced this pull request Apr 20, 2023
cushon added a commit to cushon/beam that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants