-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate nullness errors from MongoDbIO #26481
Conversation
eafe7b1
to
9bf203b
Compare
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I don't know MongoDbIO to know if any of these annotations might be inaccurate, but all the annotations follow from what existed before.
Yea I don't really know the IO other than the digging I did because I happened to be touching it. I believe I mostly just added annotations that were clearly necessary and checks that were also clearly necessary. And beyond that I trust the tests. |
My main goal is to remove the blanket suppressions so that people don't apply them to new code produced by copy/paste. |
I did also potentially add some "setting to null" that will allow things to be GC'd, but not in a way that will matter. |
I didn't try to change the design. There are probably ways to redesign the internals a bit to consolidate the checks and get better messages. But as it is they would just be NPEs in random places, so this allows us to turn on the type checking that will protect any refactor from problems.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.