Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Update protobuf version to 4.23 #26744

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

riteshghorse
Copy link
Contributor

@riteshghorse riteshghorse commented May 17, 2023

Updated protobuf version and generated all requirements for base image.
Part of #25590


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@riteshghorse
Copy link
Contributor Author

R: @tvalentyn @AnandInguva

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #26744 (aa4976d) into master (7caadb2) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #26744   +/-   ##
=======================================
  Coverage   72.04%   72.05%           
=======================================
  Files         745      745           
  Lines      101204   101204           
=======================================
+ Hits        72917    72924    +7     
+ Misses      26828    26821    -7     
  Partials     1459     1459           
Flag Coverage Δ
python 81.08% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/setup.py 0.00% <ø> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AnandInguva
Copy link
Contributor

Run Python_Runners PreCommit

@riteshghorse
Copy link
Contributor Author

retest this please

@tvalentyn
Copy link
Contributor

retest commands will not rerun GH actions. You can click to rerun in the actions UI.

@riteshghorse
Copy link
Contributor Author

I think I'll merge the PR with current successful test.. seems like an issue with macos tests anyway also in #26747

@riteshghorse riteshghorse merged commit 9e728ab into master May 17, 2023
lostluck pushed a commit to lostluck/beam that referenced this pull request May 18, 2023
Dippatel98 pushed a commit to Dippatel98/beam that referenced this pull request Jun 5, 2023
bullet03 pushed a commit to akvelon/beam that referenced this pull request Aug 11, 2023
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
@Abacn Abacn deleted the protobuf-update branch August 22, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants