Revert "Updates Python ExternalTransform to use the transform service when needed (#27228)" #27343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when needed (apache#27228)" This reverts commit d545243.
|
R: @chamikaramj |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #27343 +/- ##
==========================================
- Coverage 71.49% 71.31% -0.18%
==========================================
Files 858 853 -5
Lines 104809 103536 -1273
==========================================
- Hits 74934 73841 -1093
+ Misses 28327 28147 -180
Partials 1548 1548
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I think the failure is very specific to the way the failing test is run internally at Google (so not a widespread issue). Testing a fix. |
|
Sent #27345 |
|
Thanks @chamikaramj, closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d545243 (#27228)
It is currently failing tests with:
For environments that were working completely fine. This validation was added by #27228
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.