Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windmill proto #27361

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Fix windmill proto #27361

merged 1 commit into from
Jul 5, 2023

Conversation

y1chi
Copy link
Contributor

@y1chi y1chi commented Jul 5, 2023

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we missing a test that would've caught this? (doesn't need to block this PR, but we should follow up with one)

@y1chi
Copy link
Contributor Author

y1chi commented Jul 5, 2023

Are we missing a test that would've caught this? (doesn't need to block this PR, but we should follow up with one)

I just recently merged an old PR #23492 that had the check ran before the latest status of the proto. I think if re-run the checks it will fail to build. But the conflict is obvious so I didn't attempt to re-run the checks.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@y1chi y1chi merged commit 24fa67f into apache:master Jul 5, 2023
8 of 9 checks passed
andreydevyatkin pushed a commit to akvelon/beam that referenced this pull request Jul 7, 2023
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Jul 10, 2023
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Jul 17, 2023
bullet03 pushed a commit to akvelon/beam that referenced this pull request Aug 11, 2023
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants