Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use_public_ips to Go Dataflow Runner #28308

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

jrmccluskey
Copy link
Contributor

Adds handling for being passed use_public_ips instead of no_use_public_ips. Adds some extra validation to throw an error if provided both flags with the same value.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@jrmccluskey
Copy link
Contributor Author

@lostluck I didn't love this approach, but it looks like there's no easy way to have an alias flag where the meaning is opposite to the actual boolean being stored?

@jrmccluskey
Copy link
Contributor Author

CC: @bvolpato

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #28308 (e8766d5) into master (d616fc2) will decrease coverage by 0.02%.
Report is 57 commits behind head on master.
The diff coverage is 52.94%.

@@            Coverage Diff             @@
##           master   #28308      +/-   ##
==========================================
- Coverage   72.28%   72.27%   -0.02%     
==========================================
  Files         678      679       +1     
  Lines       99958   100000      +42     
==========================================
+ Hits        72256    72271      +15     
- Misses      26126    26152      +26     
- Partials     1576     1577       +1     
Flag Coverage Δ
go 53.59% <52.94%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/go/pkg/beam/runners/dataflow/dataflow.go 62.50% <52.94%> (+0.63%) ⬆️

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Agreed. It's rough. Not sure if we can do much better though.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jrmccluskey jrmccluskey merged commit 7c1c250 into apache:master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants