-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buffered logger to the Python bootloader #28317
Conversation
CC: @tvalentyn |
Codecov Report
@@ Coverage Diff @@
## master #28317 +/- ##
==========================================
- Coverage 72.34% 72.33% -0.02%
==========================================
Files 680 680
Lines 100280 100323 +43
==========================================
+ Hits 72552 72566 +14
- Misses 26152 26184 +32
+ Partials 1576 1573 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Run PythonLint PreCommit |
Adds the buffered logger type to the Python bootloader script, capturing subprocess output and assigning an appropriate severity to them over the FnAPI (debug if the subprocess returns exit code 0, error if the subprocess returns exit code 1.) Also removes the quiet directive from pip invocations so full output is captured.
Example of new pip output, with package information logged appropriately:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.