Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin orjson dependency. #28322

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Pin orjson dependency. #28322

merged 2 commits into from
Sep 6, 2023

Conversation

tvalentyn
Copy link
Contributor

Remediation for: #28318.
If orjson doesn't come up with a fix, we can pin the last tested version.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #28322 (d5de321) into master (67e88d9) will increase coverage by 0.00%.
Report is 11 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #28322   +/-   ##
=======================================
  Coverage   72.34%   72.35%           
=======================================
  Files         680      680           
  Lines      100298   100323   +25     
=======================================
+ Hits        72562    72587   +25     
- Misses      26162    26163    +1     
+ Partials     1574     1573    -1     
Flag Coverage Δ
python 82.92% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/python/setup.py 0.00% <ø> (ø)

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dankuchler
Copy link

I believe you could pin the dependency to orjson 3.9.2 - as we are currently running orjson 3.9.2 without problems and the orjson github project issue mentioned others were reverting from 3.9.4 to 3.9.2 to avoid the problem.

@tvalentyn
Copy link
Contributor Author

ok. done

@tvalentyn tvalentyn marked this pull request as ready for review September 6, 2023 17:56
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn tvalentyn merged commit 24a47b4 into apache:master Sep 6, 2023
93 of 96 checks passed
@tvalentyn tvalentyn deleted the orjson branch September 6, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants