-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to control automatic exception sampling in Python (disabled) #28418
Conversation
R: @udim |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #28418 +/- ##
==========================================
- Coverage 72.33% 72.31% -0.02%
==========================================
Files 682 683 +1
Lines 100541 100633 +92
==========================================
+ Hits 72723 72771 +48
- Misses 26243 26287 +44
Partials 1575 1575
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
# When true, enables the sampling of all PCollections and exceptions. | ||
enable_data_sampling = DataSampler._ENABLE_DATA_SAMPLING in experiments | ||
|
||
if enable_data_sampling or always_on_exception_sampling: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If both of these flags are true, only exception sampling is enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah gotcha, looks like Java has the logic but not here. Added it here and added a test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Java PR has the additional check: https://github.com/apache/beam/pull/28403/files#diff-36700390d81df614d72f1040b223c74ce99a4615ab209bbbe7ee4675f8c16ae3R75
Run Python_Runners PreCommit |
Run Portable_Python PreCommit |
This enables exception sampling when either the "enable_data_sampling" or "enable_always_on_exception_sampling" experiment is present. This disables automatic exception sampling when "disable_always_on_exception_sampling" is given.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.