Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch #28663

Conversation

kennknowles
Copy link
Member

You can run many tests automatically using release/src/main/scripts/mass_comment.py.

@kennknowles kennknowles force-pushed the postcommit_validation_pr branch from 3ea7d85 to 25c7084 Compare September 26, 2023 12:50
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@kennknowles
Copy link
Member Author

run java precommit

@kennknowles
Copy link
Member Author

Run Beam Metrics deployment

@kennknowles
Copy link
Member Author

Run Chicago Taxi on Dataflow

@kennknowles
Copy link
Member Author

Run Chicago Taxi on Flink

@kennknowles
Copy link
Member Author

Run CommunityMetrics PreCommit

@kennknowles
Copy link
Member Author

Run Dataflow Runner Nexmark Tests

@kennknowles
Copy link
Member Author

Run Dataflow Runner Tpcds Tests

@kennknowles
Copy link
Member Author

Run Dataflow Runner V2 Java 11 Nexmark Tests

@kennknowles
Copy link
Member Author

Run Dataflow Runner V2 Java 17 Nexmark Tests

@kennknowles
Copy link
Member Author

Run Dataflow Runner V2 Nexmark Tests

@kennknowles
Copy link
Member Author

Run Dataflow Streaming ValidatesRunner

@kennknowles
Copy link
Member Author

Run Dataflow ValidatesRunner Java 11

@kennknowles
Copy link
Member Author

Run Dataflow ValidatesRunner Java 17

@kennknowles
Copy link
Member Author

Run Dataflow ValidatesRunner

@kennknowles
Copy link
Member Author

Run Direct Runner Nexmark Tests

@kennknowles
Copy link
Member Author

Run Direct ValidatesRunner Java 11

@kennknowles
Copy link
Member Author

Run Direct ValidatesRunner Java 17

@kennknowles
Copy link
Member Author

Run Direct ValidatesRunner in Java 11

@kennknowles
Copy link
Member Author

Run Direct ValidatesRunner

@kennknowles
Copy link
Member Author

Run Flink Runner Nexmark Tests

@kennknowles
Copy link
Member Author

Run Flink Runner Tpcds Tests

@kennknowles
Copy link
Member Author

Run Flink ValidatesRunner Java 11

@kennknowles
Copy link
Member Author

Run Flink ValidatesRunner

@kennknowles
Copy link
Member Author

Run Go Flink ValidatesRunner

@kennknowles
Copy link
Member Author

Run Go PostCommit

@kennknowles
Copy link
Member Author

Run Go PreCommit

@kennknowles
Copy link
Member Author

Run Go Samza ValidatesRunner

@kennknowles
Copy link
Member Author

Run Go PreCommit

@kennknowles
Copy link
Member Author

Run GoPortable PreCommit

@kennknowles
Copy link
Member Author

Run Java Portability examples on Dataflow with Java 11

@je-ik
Copy link
Contributor

je-ik commented Oct 10, 2023

Run Python_PVR_Flink PreCommit

@je-ik
Copy link
Contributor

je-ik commented Oct 10, 2023

Run Flink ValidatesRunner Java 11

1 similar comment
@je-ik
Copy link
Contributor

je-ik commented Oct 10, 2023

Run Flink ValidatesRunner Java 11

@kennknowles
Copy link
Member Author

Run Java_Pulsar_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

run spark validatesrunner

@kennknowles
Copy link
Member Author

Run Java Dataflow V2 ValidatesRunner Streaming

@kennknowles
Copy link
Member Author

Run Dataflow Runner Tpcds Tests

@kennknowles
Copy link
Member Author

Run Flink ValidatesRunner Java 11

@je-ik
Copy link
Contributor

je-ik commented Oct 10, 2023

Run Flink ValidatesRunner Java 11

The Flink lifecycle ParDoTests are flaky as hell. I think we have tracking issues for those, unfortunately there is nobody with enough interest fixing it. :-/

@kennknowles
Copy link
Member Author

OK gotcha. I will not bother deflaking them here.

@kennknowles
Copy link
Member Author

We could disable them

@kennknowles
Copy link
Member Author

Specifically, we probably should list Flink as not reliably supporting teardown after exceptions are thrown.

@kennknowles
Copy link
Member Author

Run Java_SingleStore_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Run Java Spark PortableValidatesRunner Batch

@kennknowles
Copy link
Member Author

Run PostCommit_Java_Dataflow

@kennknowles
Copy link
Member Author

Run PostCommit_Java_DataflowV2

@je-ik
Copy link
Contributor

je-ik commented Oct 10, 2023

There are other tests besides tearDown that tend to fail. I didn't have time to dig into it, I'm afraid disabling them will leave them disabled for good. Though yes, the current state is not too much helpful either.

@kennknowles
Copy link
Member Author

Run Java SingleStoreIO_IT

@kennknowles
Copy link
Member Author

Run XVR_GoUsingJava_Dataflow PostCommit

@kennknowles
Copy link
Member Author

It looks like "GoUsingJava" is failing due to task :sdks:python:test-suites:direct:xlang:validatesCrossLanguageRunnerPythonUsingSql @chamikaramj @lostluck

@kennknowles
Copy link
Member Author

hmm there haven't been any changes to singlestore since 2.50.0 where this test was green

@kennknowles
Copy link
Member Author

it is also green reliably on master

@kennknowles
Copy link
Member Author

Oh actually I think it was 2.49.0 where it was green.

@kennknowles
Copy link
Member Author

Run XVR_Direct PostCommit

@kennknowles
Copy link
Member Author

https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/ tells me to not worry about that particular suite (or to worry a lot)

@kennknowles kennknowles deleted the postcommit_validation_pr branch October 18, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants