Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Java Examples ARM GHA on Java8 #29117

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Oct 24, 2023

Follow up of #28969

After the change the PostCommit Java Example ARM failing due to

A problem occurred evaluating project ':runners:google-cloud-dataflow-java'.
> Unknown Java Version 8 for setting additional java options

This PR

  • Skips unsupported ver for -PtestJavaVersion option. This fixes Java Examples ARM GHA on Java8

this preserve the original logic before #28969 that is no-op when -PtestJavaVersion=8 is set. This happens to be configured in PostCommit ARM.

  • Fixes missing version matrix element in readme.md

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

* Skip unsupported ver for -PtestJavaVersion option
  this fixes Java Examples ARM GHA on Java8

* Fix missing readme
@github-actions github-actions bot added the build label Oct 24, 2023
@Abacn
Copy link
Contributor Author

Abacn commented Oct 24, 2023

Tested by run the equivalent command locally:

./gradlew :runners:google-cloud-dataflow-java:arm:examplesJavaRunnerV2IntegrationTestARM -PtestJavaVersion=8 -Pjava8Home=.../.sdkman/candidates/java/8.0.322-zulu -Pcontainer-architecture-list=arm64 -Ppush-containers -Pdocker-repository-root=us.gcr.io/apache-beam-testing/github-actions -Pdocker-tag=java21test -PdisableSpotlessCheck=true -PdisableCheckStyle=true -PskipCheckerFramework

passed jobIds

2023-10-24_08_41_00-10801098760830802204
2023-10-24_08_41_03-14774137446205140215
2023-10-24_08_41_05-8911072195670644574
2023-10-24_08_41_12-7715440097359109658

Note that "-PtestJavaVersion=8 -Pjava8Home=...." are not necessary for java8 test (but we tolerate the redundant config as Java version tests are structured in this way).

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #29117 (715bbf0) into master (bc06581) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #29117   +/-   ##
=======================================
  Coverage   38.37%   38.37%           
=======================================
  Files         686      686           
  Lines      101689   101689           
=======================================
  Hits        39021    39021           
  Misses      61089    61089           
  Partials     1579     1579           
Flag Coverage Δ
python 29.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Abacn
Copy link
Contributor Author

Abacn commented Oct 24, 2023

Testing Java21 on ARM has a few blockers under the current GHA setup (run everything in single Java version) . I have a working branch trying to resolve them, but currently blocked by shadow plugin not yet support java21: Abacn@7aff7b5

This essentially means beam does not yet support compiling on Java21. We need to restructure the ARM postcommit to be compiled with Java8 (beam) + Java21 (test) as what I just did for JPMS. Leave this as future task.

@Abacn Abacn marked this pull request as ready for review October 24, 2023 17:17
@Abacn
Copy link
Contributor Author

Abacn commented Oct 24, 2023

R: @tvalentyn

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@tvalentyn tvalentyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Abacn
Copy link
Contributor Author

Abacn commented Oct 24, 2023

Run Java_Examples_Dataflow_ARM PostCommit 8

running: https://github.com/apache/beam/actions/runs/6630847726/job/18013126134

update: passed, merging for now

@Abacn Abacn merged commit 02b84b8 into apache:master Oct 24, 2023
46 checks passed
@Abacn Abacn deleted the fixarmpostcommit branch October 24, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants