-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Java Examples ARM GHA on Java8 #29117
Conversation
* Skip unsupported ver for -PtestJavaVersion option this fixes Java Examples ARM GHA on Java8 * Fix missing readme
Tested by run the equivalent command locally:
passed jobIds
Note that "-PtestJavaVersion=8 -Pjava8Home=...." are not necessary for java8 test (but we tolerate the redundant config as Java version tests are structured in this way). |
Codecov Report
@@ Coverage Diff @@
## master #29117 +/- ##
=======================================
Coverage 38.37% 38.37%
=======================================
Files 686 686
Lines 101689 101689
=======================================
Hits 39021 39021
Misses 61089 61089
Partials 1579 1579
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Testing Java21 on ARM has a few blockers under the current GHA setup (run everything in single Java version) . I have a working branch trying to resolve them, but currently blocked by shadow plugin not yet support java21: Abacn@7aff7b5 This essentially means beam does not yet support compiling on Java21. We need to restructure the ARM postcommit to be compiled with Java8 (beam) + Java21 (test) as what I just did for JPMS. Leave this as future task. |
R: @tvalentyn |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Run Java_Examples_Dataflow_ARM PostCommit 8 running: https://github.com/apache/beam/actions/runs/6630847726/job/18013126134 update: passed, merging for now |
Follow up of #28969
After the change the PostCommit Java Example ARM failing due to
This PR
this preserve the original logic before #28969 that is no-op when
-PtestJavaVersion=8
is set. This happens to be configured in PostCommit ARM.Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.