Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RRIO] [Testing] Add a 10/1s Quota Refresher #29295

Merged

Conversation

damondouglas
Copy link
Contributor

This PR addresses #28932, #28930, and #28926 with a Refresher configuration that sets a quota at 10 elements per 1s rate.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the infra label Nov 3, 2023
@damondouglas damondouglas changed the title [RRIO] [Testing] Add a 10/1s Refresher [RRIO] [Testing] Add a 10/1s Quota Refresher Nov 3, 2023
@damondouglas damondouglas marked this pull request as ready for review November 3, 2023 17:30
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Go, not as familiar with the yaml work

@jrmccluskey
Copy link
Contributor

Just lmk when you're ready for this to get merged

@damondouglas
Copy link
Contributor Author

@jrmccluskey Thank you for reviewing. Would you like me to squash/merge or would you?

@jrmccluskey
Copy link
Contributor

I got it

@jrmccluskey jrmccluskey merged commit 42bd0d0 into apache:master Nov 3, 2023
3 checks passed
@damondouglas damondouglas deleted the rrio-testing-10-per-1s-refresher branch November 3, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants