[RRIO] [Throttle] [Cache] Implement Throttle and Cache using an external resource. #29401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigning reviewers. If you would like to opt out of this review, comment R: @m-trieu for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
R: @m-trieu |
Abacn
reviewed
Nov 15, 2023
sdks/java/io/rrio/src/test/java/org/apache/beam/io/requestresponse/CacheTestIT.java
Outdated
Show resolved
Hide resolved
sdks/java/io/rrio/src/test/java/org/apache/beam/io/requestresponse/CallTest.java
Outdated
Show resolved
Hide resolved
sdks/java/io/rrio/src/test/java/org/apache/beam/io/requestresponse/EchoITOptions.java
Outdated
Show resolved
Hide resolved
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Cache.java
Outdated
Show resolved
Hide resolved
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Call.java
Show resolved
Hide resolved
...a/io/rrio/src/main/java/org/apache/beam/io/requestresponse/ThrottleWithExternalResource.java
Outdated
Show resolved
Hide resolved
...a/io/rrio/src/main/java/org/apache/beam/io/requestresponse/ThrottleWithExternalResource.java
Outdated
Show resolved
Hide resolved
...a/io/rrio/src/main/java/org/apache/beam/io/requestresponse/ThrottleWithExternalResource.java
Outdated
Show resolved
Hide resolved
...a/io/rrio/src/main/java/org/apache/beam/io/requestresponse/ThrottleWithExternalResource.java
Outdated
Show resolved
Hide resolved
m-trieu
reviewed
Nov 16, 2023
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Cache.java
Outdated
Show resolved
Hide resolved
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/Cache.java
Outdated
Show resolved
Hide resolved
sdks/java/io/rrio/src/main/java/org/apache/beam/io/requestresponse/RedisClient.java
Show resolved
Hide resolved
m-trieu
approved these changes
Nov 20, 2023
Abacn
approved these changes
Nov 22, 2023
...rrio/src/test/java/org/apache/beam/io/requestresponse/EchoGRPCCallerWithSetupTeardownIT.java
Outdated
Show resolved
Hide resolved
Naireen
pushed a commit
to Naireen/beam
that referenced
this pull request
Jan 3, 2024
…nal resource. (apache#29401) * WIP: Implement CacheSerializer and providers * wip * Condense Throttle into one class * wip * Implement Throttle and Cache * Update javadoc * Edit per PR comments * Refacter per PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #28932 , closes #28924, closes #28922, closes #28908, closes #28907 implementing all transforms that utilize an external resource. This PR is able to close many issues as it was realized that much can be implemented reusing the existing Call PTransform.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.