[YAML] Clean up some confusing error messages. #29481
Conversation
* Provide sane defaults rather than NullPtrExceptions for optional BigQuery parameters. * Better error when cross-language is used with (incompatible) local streaming Python runner. * Add format and schema to readme PubSub examples.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #29481 +/- ##
=======================================
Coverage 37.84% 37.85%
=======================================
Files 690 690
Lines 101352 101311 -41
=======================================
- Hits 38356 38350 -6
+ Misses 61400 61368 -32
+ Partials 1596 1593 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
R: @Polber |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
| class VerifyNoCrossLanguageTransforms(PipelineVisitor): | ||
| """Visitor determining whether a Pipeline uses a TestStream.""" | ||
| def visit_transform(self, applied_ptransform): | ||
| if isinstance(applied_ptransform.transform, ExternalTransform): | ||
| raise RuntimeError( | ||
| "Streaming Python direct runner " | ||
| "does not support cross-language pipelines.") |
There was a problem hiding this comment.
Should there be a FR for this?
There was a problem hiding this comment.
https://issues.apache.org/jira/browse/BEAM-7514 is probably the closest we have.
* Provide sane defaults rather than NullPtrExceptions for optional BigQuery parameters. * Better error when cross-language is used with (incompatible) local streaming Python runner. * Add format and schema to readme PubSub examples.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.