[WIP] try new protobuf #30556
[WIP] try new protobuf #30556
Conversation
riteshghorse
force-pushed
the
protobuf-wrapper
branch
from
5930e3d
to
40d8381
Compare
| result.FromMicroseconds(micros) | ||
| return result | ||
| elif isinstance(result, timestamp_pb2.Timestamp): | ||
| result.seconds = micros // _MICROS_TO_SECONDS |
There was a problem hiding this comment.
can we add some comments here about why we do these conversions?
There was a problem hiding this comment.
+1. add brief comment why we don't use timestamp_pb2.Timestamp.FromMicroseconds()
and a reference an issue that has details.
|
CC: @tvalentyn |
| @@ -36,6 +35,10 @@ | |||
|
|
|||
| message_types = (message.Message, ) | |||
|
|
|||
| _MICROS_TO_SECONDS = 1000000 | |||
There was a problem hiding this comment.
| _MICROS_TO_SECONDS = 1000000 | |
| _SECONDS_TO_MICROS = 10**6 |
ditto elsewhere
| result.FromMicroseconds(micros) | ||
| return result | ||
| elif isinstance(result, timestamp_pb2.Timestamp): | ||
| result.seconds = micros // _MICROS_TO_SECONDS |
There was a problem hiding this comment.
+1. add brief comment why we don't use timestamp_pb2.Timestamp.FromMicroseconds()
and a reference an issue that has details.
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.