Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry test_big_query_legacy_sql #31417

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Conversation

liferoad
Copy link
Collaborator

Addresses #30513 and #29617

Simply retry this test for now.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label python.
R: @damondouglas for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn
Copy link
Contributor

tvalentyn commented May 28, 2024

PTAL: #29617 (comment)

If the problem is in the wheel, a retry also won't fix it - we'd have to rebuild the wheel.

@liferoad
Copy link
Collaborator Author

PTAL: #29617 (comment)

If the problem is in the wheel, a retry also won't fix it - we'd have to rebuild the wheel.

I suggest we can retry this for now to check whether it can reduce the flaky rate.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Reminder, please take a look at this pr: @riteshghorse @damondouglas

@liferoad liferoad requested review from Abacn and removed request for tvalentyn June 4, 2024 12:34
Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liferoad
Copy link
Collaborator Author

liferoad commented Jun 5, 2024

Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @liferoad

@damondouglas damondouglas merged commit 03d553e into apache:master Jun 6, 2024
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants