Solace Read connector: adding Basic Authentication support #31541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
This was referenced Jun 7, 2024
16 tasks
bzablocki
force-pushed
the
solace-connector-3-jcsmp-auth
branch
from
7ceeece
to
b22e38e
Compare
bzablocki
force-pushed
the
solace-connector-3-jcsmp-auth
branch
from
b22e38e
to
dc9bced
Compare
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
damondouglas
requested changes
Jun 27, 2024
.../solace/src/main/java/org/apache/beam/sdk/io/solace/broker/BasicAuthJcsmpSessionService.java
Show resolved
Hide resolved
.../solace/src/main/java/org/apache/beam/sdk/io/solace/broker/BasicAuthJcsmpSessionService.java
Outdated
Show resolved
Hide resolved
.../solace/src/main/java/org/apache/beam/sdk/io/solace/broker/BasicAuthJcsmpSessionService.java
Outdated
Show resolved
Hide resolved
.../solace/src/main/java/org/apache/beam/sdk/io/solace/broker/BasicAuthJcsmpSessionService.java
Outdated
Show resolved
Hide resolved
.../solace/src/main/java/org/apache/beam/sdk/io/solace/broker/BasicAuthJcsmpSessionService.java
Show resolved
Hide resolved
.../src/main/java/org/apache/beam/sdk/io/solace/broker/BasicAuthJcsmpSessionServiceFactory.java
Show resolved
Hide resolved
bzablocki
force-pushed
the
solace-connector-3-jcsmp-auth
branch
from
dc9bced
to
626f7e9
Compare
|
@bzablocki Could you click the "re-request" review next to my GitHub username above, after addressing comments when this PR is ready for review again. |
damondouglas
reviewed
Jul 1, 2024
.../solace/src/main/java/org/apache/beam/sdk/io/solace/broker/BasicAuthJcsmpSessionService.java
Show resolved
Hide resolved
damondouglas
approved these changes
Jul 1, 2024
damondouglas
approved these changes
Jul 1, 2024
|
Merging after checks pass... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 3rd PR for the Solace Read connector (addresses #31440).
It depends on the #31539 and #31476 (root).
The files that are added/modified in this PR, comparing to the #31539:
These are implementations of SessionService, SessionServiceFactory and MessageReceiver. SessionServiceFactory can be used as an argument to
SolaceIO.withSessionServiceFactory(...).Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.