[Python] Add warning to temp_location and staging_location when the bucket has soft delete enabled #31550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunping
force-pushed
the
check-soft-delete-on-temp-python
branch
from
49fd5ea
to
9788a48
Compare
shunping
force-pushed
the
check-soft-delete-on-temp-python
branch
from
d3f3f4c
to
366ee11
Compare
|
R: @Abacn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
shunping
force-pushed
the
check-soft-delete-on-temp-python
branch
from
a94c1cb
to
c68709c
Compare
shunping
force-pushed
the
check-soft-delete-on-temp-python
branch
2 times, most recently
from
654b29d
to
161fac9
Compare
shunping
force-pushed
the
check-soft-delete-on-temp-python
branch
from
161fac9
to
3e2623f
Compare
|
We can encode this warning in beam for this particular setting. However in general we should think about whether this kind of billing warning is suitable in beam code, or more suitable to be emitted elsewhere (like Dataflow recommendation). afaik there are also other "trap" GCS settings that could bleed billing:
and there might be more. Ideally dataflow service side recommendation would be more versatile than the SDK side encoded warning |
Abacn
approved these changes
Jun 10, 2024
3 tasks
shunping
added a commit
to shunping/beam
that referenced
this pull request
Jun 12, 2024
…ucket has soft delete enabled (apache#31550) * Add warning if soft delete is enabled in temp or staging buckets.
Open
16 tasks
kennknowles
added a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@address #31330 for Python SDK