Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solace Read connector: watermark-calculation related classes #31595

Merged
merged 48 commits into from
Jun 17, 2024

Conversation

bzablocki
Copy link
Contributor

@bzablocki bzablocki commented Jun 13, 2024

PR for the Solace Read connector (addresses #31440).

Adds watermark-related classes.

Depends on #31594

Relevant changes: https://github.com/apache/beam/pull/31595/commits/3847876ed9a26ef2177d9544ddd83986a3d96541


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

…-0-watermark

# Conflicts:
#	sdks/java/io/solace/build.gradle
#	sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/SolaceIO.java
@github-actions github-actions bot removed the build label Jun 14, 2024
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM after adding minimum documentation in place

@bzablocki
Copy link
Contributor Author

Documentation added, thank you @Abacn!

@Abacn Abacn merged commit 372ebd8 into apache:master Jun 17, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants