[YAML] Allow explicitly including external provider lists. #31604
Conversation
This can be more useful than jinja's {% include %} as it can refer
to urls, does not have to assume perfect indentation of the included
file, and avoids applying templitization to the included file.
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @liferoad for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| with FileSystems.open(provider_spec['include']) as fin: | ||
| content = fin.read() | ||
| else: | ||
| raise |
There was a problem hiding this comment.
shall we raise a runtime error here?
There was a problem hiding this comment.
Is there an advantage to raising a RuntimeError rather than preserving the specific error that fetching the URL produced?
There was a problem hiding this comment.
explicitly mention what kind of providers are supported? or maybe we can update raise ValueError(f"Invalid provider spec: {provider_spec}")? basically making the error message more actionable.
There was a problem hiding this comment.
Good call. I've added more explicit error messages.
This can be more useful than jinja's {% include %} as it can refer to urls, does not have to assume perfect indentation of the included file, and avoids applying templitization to the included file.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.