-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use intended version for elasticsearch tests #31639
Conversation
* And both versions are EOL
@@ -34,6 +34,7 @@ | |||
* <p>This is independent from the tests so that for read tests it can be run separately after data | |||
* store creation rather than every time (which can be more fragile.) | |||
*/ | |||
@SuppressWarnings("nullness") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these test fixtures belong to main scope, and there is a backlog task eliminate "testRuntimeMigration" (#16307).
After moving to main scope checkerframework errors seen. This are test fixtures so fix is of lower priority and deferred.
@@ -98,7 +98,6 @@ jobs: | |||
uses: ./.github/actions/gradle-command-self-hosted-action | |||
with: | |||
gradle-command: | | |||
:sdks:java:io:elasticsearch-tests:elasticsearch-tests-5:build \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change on github action won't be effective in PR so the ElasticSearch IO Direct would fail due to target not found.
Test on upstream branch passed: https://github.com/apache/beam/actions/runs/9573608254/job/26395346618
R: @Amar3tto |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
@Abacn can you please investigate the failing check[1] that's reporting elasticsearch-5 as not being found in the project? [1] https://github.com/apache/beam/actions/runs/9573605584/job/26395339465 |
Agreed that these versions are EOL, but we should likely include release notes. It might also be preferred to formally deprecate for 1 release version as well. |
test passed, explained here: #31639 (comment) we didn't actually test elasticsearch-5 : #31640 , In other word Beam has been exercising elasticsearch 7 and 8 tests only for long so there is not actual change on support status. |
Fix #31640 --- by tear them down
Please add a meaningful description for your change here
Remove elasticsearch-test-5,6 which never exercised on intended version, and both versions are EOL
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.