Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish a blog post - deploy-python-pipeline-on-flink-runner #31655

Merged
merged 28 commits into from
Jun 26, 2024
Merged

Publish a blog post - deploy-python-pipeline-on-flink-runner #31655

merged 28 commits into from
Jun 26, 2024

Conversation

jaehyeon-kim
Copy link
Contributor

Please add a meaningful description for your change here

Publish a new blog post titled Deploy Python Pipelines on Kubernetes via the Flink Runner.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @rszper for label website.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@liferoad
Copy link
Collaborator

@liferoad
Copy link
Collaborator

@rszper Could you review the blog? Thanks!

@liferoad
Copy link
Collaborator

@damondouglas FYI.

jaehyeon-kim and others added 20 commits June 23, 2024 20:22
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
jaehyeon-kim and others added 4 commits June 23, 2024 20:29
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md

Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaehyeon-kim thank you for working on this. Could you work with @rszper and resolve any unresolved comments so we know when this is ready for merge? I'll have a look at it myself after comments resolve.

jaehyeon-kim and others added 2 commits June 25, 2024 08:02
Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
@jaehyeon-kim
Copy link
Contributor Author

Hi @rszper

I just found the python code block hides code snippets and it is changed from using {{< highlight py >}} to ```python. The applicable lines start at 273, 507, and 762.

Copy link
Contributor

R: @kennknowles for final approval

@kennknowles
Copy link
Member

R: @liferoad

you are now a committer :-)

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@liferoad
Copy link
Collaborator

I am going to wait for @damondouglas to take a quick look. Thanks.

@liferoad liferoad merged commit c1c853f into apache:master Jun 26, 2024
6 checks passed
@Abacn
Copy link
Contributor

Abacn commented Jun 26, 2024

when there are many commits sometimes it is good to use "squash and merge" otherwise the git log flood with the intermediate commits - https://github.com/apache/beam/commits/master/?before=c1c853fcc520e8519dd0baf19d7714f345979bcc+35

@kennknowles
Copy link
Member

If you use git commit --fixup HEAD then it will make very obvious commit messages. We could/should have GHA checks or something that go red when there are non-desired commits in the PR. We should still support multi-commit PRs but only if they are organized into meaningful commits. Maybe the description can tag #multicommit or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants