-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish a blog post - deploy-python-pipeline-on-flink-runner #31655
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @rszper for label website. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Thanks for the blog! https://apache-beam-website-pull-requests.storage.googleapis.com/31655/blog/deploy-python-pipeline-on-flink-runner/index.html has the staged file. Looks great! |
@rszper Could you review the blog? Thanks! |
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
@damondouglas FYI. |
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
…nk-runner.md Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaehyeon-kim thank you for working on this. Could you work with @rszper and resolve any unresolved comments so we know when this is ready for merge? I'll have a look at it myself after comments resolve.
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/deploy-python-pipeline-on-flink-runner.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Rebecca Szper <98840847+rszper@users.noreply.github.com>
Hi @rszper I just found the python code block hides code snippets and it is changed from using {{< highlight py >}} to ```python. The applicable lines start at 273, 507, and 762. |
R: @kennknowles for final approval |
R: @liferoad you are now a committer :-) |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
I am going to wait for @damondouglas to take a quick look. Thanks. |
when there are many commits sometimes it is good to use "squash and merge" otherwise the git log flood with the intermediate commits - https://github.com/apache/beam/commits/master/?before=c1c853fcc520e8519dd0baf19d7714f345979bcc+35 |
If you use |
Please add a meaningful description for your change here
Publish a new blog post titled Deploy Python Pipelines on Kubernetes via the Flink Runner.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.