Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/tetratelabs/wazero from 1.7.0 to 1.7.3 in /sdks #31672

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 24, 2024

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Bumps github.com/tetratelabs/wazero from 1.7.0 to 1.7.3.

Release notes

Sourced from github.com/tetratelabs/wazero's releases.

v1.7.3

Time to celebrate the new wazero release! This time has not only the important bugs fixes just like before, but more importantly comes with the drastic "compilation time" performance improvements!

Bug fixes

Compilation perf improvements

@​mathetake worked so hard to improve the compilation performance which some users had raised issue about since the release of the optimizing compiler in 1.7.0. The idea is that even though this is partly because it is "optimizing", there are still rooms for improvements in its codebase to use less CPU/memory.

The below is the compilation time benchmark on the various standard library tests for Zig, Go and TinyGo compared to the previous v1.7.2. You can see the huge results up to like 50% faster and ~50% less memory usage. Note that this doesn't affect any runtime performance -- that means your code runs just exactly like before while having faster compilation!😎

goos: darwin
goarch: arm64
pkg: github.com/tetratelabs/wazero/internal/integration_test/stdlibs
                                                   │   old.txt    │              new.txt               │
                                                   │    sec/op    │   sec/op     vs base               │
Zig/Compile/test-opt.wasm-10                           4.872 ± 2%    3.389 ± 3%  -30.44% (p=0.001 n=7)
Zig/Compile/test.wasm-10                               5.926 ± 2%    4.162 ± 1%  -29.76% (p=0.001 n=7)
TinyGo/Compile/container_heap.test-10                 677.2m ± 0%   306.3m ± 1%  -54.76% (p=0.001 n=7)
TinyGo/Compile/container_list.test-10                 673.2m ± 1%   309.3m ± 8%  -54.05% (p=0.001 n=7)
TinyGo/Compile/container_ring.test-10                 665.1m ± 1%   299.5m ± 0%  -54.97% (p=0.001 n=7)
TinyGo/Compile/crypto_des.test-10                     686.4m ± 0%   311.6m ± 0%  -54.61% (p=0.001 n=7)
TinyGo/Compile/crypto_md5.test-10                     685.5m ± 1%   312.7m ± 4%  -54.38% (p=0.001 n=7)
TinyGo/Compile/crypto_rc4.test-10                     666.5m ± 0%   297.9m ± 0%  -55.31% (p=0.001 n=7)
TinyGo/Compile/crypto_sha1.test-10                    683.7m ± 0%   310.1m ± 0%  -54.65% (p=0.001 n=7)
TinyGo/Compile/crypto_sha256.test-10                  692.0m ± 1%   315.0m ± 2%  -54.48% (p=0.001 n=7)
TinyGo/Compile/crypto_sha512.test-10                  692.7m ± 0%   316.6m ± 1%  -54.29% (p=0.001 n=7)
TinyGo/Compile/encoding_ascii85.test-10               680.6m ± 1%   309.3m ± 1%  -54.55% (p=0.001 n=7)
TinyGo/Compile/encoding_base32.test-10               1637.6m ± 1%   650.8m ± 0%  -60.26% (p=0.001 n=7)
TinyGo/Compile/encoding_csv.test-10                   740.0m ± 1%   333.5m ± 0%  -54.92% (p=0.001 n=7)
TinyGo/Compile/encoding_hex.test-10                   708.7m ± 3%   320.9m ± 0%  -54.72% (p=0.001 n=7)
TinyGo/Compile/go_scanner.test-10                     773.2m ± 1%   347.1m ± 6%  -55.11% (p=0.001 n=7)
TinyGo/Compile/hash.test-10                           951.8m ± 1%   410.8m ± 0%  -56.84% (p=0.001 n=7)
TinyGo/Compile/hash_adler32.test-10                   665.8m ± 1%   297.5m ± 0%  -55.32% (p=0.001 n=7)
TinyGo/Compile/hash_crc64.test-10                     893.9m ± 1%   385.1m ± 1%  -56.92% (p=0.001 n=7)
TinyGo/Compile/hash_fnv.test-10                       695.8m ± 2%   312.4m ± 0%  -55.10% (p=0.001 n=7)
TinyGo/Compile/html.test-10                            2.426 ± 1%    2.012 ± 1%  -17.07% (p=0.001 n=7)
TinyGo/Compile/internal_itoa.test-10                  662.5m ± 1%   296.0m ± 1%  -55.32% (p=0.001 n=7)
TinyGo/Compile/internal_profile.test-10               893.6m ± 1%   417.9m ± 0%  -53.24% (p=0.001 n=7)
TinyGo/Compile/math.test-10                           821.1m ± 0%   398.4m ± 0%  -51.48% (p=0.001 n=7)
TinyGo/Compile/math_cmplx.test-10                     701.7m ± 0%   338.8m ± 1%  -51.71% (p=0.001 n=7)
TinyGo/Compile/net.test-10                            755.4m ± 1%   356.5m ± 3%  -52.81% (p=0.001 n=7)
TinyGo/Compile/net_http_internal_ascii.test-10        661.5m ± 1%   296.8m ± 2%  -55.14% (p=0.001 n=7)
TinyGo/Compile/net_mail.test-10                       927.1m ± 2%   398.9m ± 2%  -56.97% (p=0.001 n=7)
TinyGo/Compile/os.test-10                             754.9m ± 0%   370.5m ± 0%  -50.92% (p=0.001 n=7)
</tr></table> 

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/tetratelabs/wazero](https://github.com/tetratelabs/wazero) from 1.7.0 to 1.7.3.
- [Release notes](https://github.com/tetratelabs/wazero/releases)
- [Commits](tetratelabs/wazero@v1.7.0...v1.7.3)

---
updated-dependencies:
- dependency-name: github.com/tetratelabs/wazero
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go labels Jun 24, 2024
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@chamikaramj
Copy link
Contributor

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @lostluck for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.37%. Comparing base (0f2e196) to head (b700b64).
Report is 44 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #31672   +/-   ##
=========================================
  Coverage     71.37%   71.37%           
  Complexity     1474     1474           
=========================================
  Files           900      900           
  Lines        114210   114210           
  Branches       1076     1076           
=========================================
+ Hits          81515    81516    +1     
+ Misses        30667    30663    -4     
- Partials       2028     2031    +3     
Flag Coverage Δ
go 54.63% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lostluck lostluck merged commit 832712a into master Jun 27, 2024
10 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/sdks/github.com/tetratelabs/wazero-1.7.3 branch June 27, 2024 17:11
acrites pushed a commit to acrites/beam that referenced this pull request Jul 17, 2024
…he#31672)

Bumps [github.com/tetratelabs/wazero](https://github.com/tetratelabs/wazero) from 1.7.0 to 1.7.3.
- [Release notes](https://github.com/tetratelabs/wazero/releases)
- [Commits](tetratelabs/wazero@v1.7.0...v1.7.3)

---
updated-dependencies:
- dependency-name: github.com/tetratelabs/wazero
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Next Action: Reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants