Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove testRuntimeMigration configuration for test-utils dependencies #31713

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jun 28, 2024

Context: #30193 (comment)

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn
Copy link
Contributor Author

Abacn commented Jul 1, 2024

The change on sdks/java/io/sparkreceiver/2/build.gradle caused test failure:

testProcessElement (org.apache.beam.sdk.io.sparkreceiver.ReadFromSparkReceiverWithOffsetDoFnTest) failed

java.lang.AssertionError: expected:<[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19]> but was:<[]>

at org.apache.beam.sdk.io.sparkreceiver.ReadFromSparkReceiverWithOffsetDoFnTest.testProcessElement(ReadFromSparkReceiverWithOffsetDoFnTest.java:143)

@Abacn
Copy link
Contributor Author

Abacn commented Jul 1, 2024

assign set of reviewers

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas for label java.
R: @ahmedabu98 for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn Abacn merged commit 2c72113 into apache:master Jul 1, 2024
34 checks passed
@Abacn Abacn deleted the testutilconfig branch July 1, 2024 19:59
acrites pushed a commit to acrites/beam that referenced this pull request Jul 17, 2024
…apache#31713)

* Remove testRuntimeMigration configuration for test-utils dependencies

* Fix test dependency direct-java configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants