Dont read from cache in sensitive workflows #31734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @Abacn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Abacn
reviewed
Jul 1, 2024
There was a problem hiding this comment.
LGTM for gradle enterprise cache.
there are two caches - gradle enterprise and github action caches. If setup-environment-action is used, the latter is always enabled:
(even disable-cache is set it only makes gradle cache read-only)
I kind of remember GHA cache is per workflow based, if so then it is fine leave it as is, good to double check.
|
Good catch, I didn't realize we use the actions cache for this - I'll disable that since we leave around actions write permissions in places (which allows writing to the cache) |
3 tasks
3 tasks
acrites
pushed a commit
to acrites/beam
that referenced
this pull request
Jul 17, 2024
* Dont read from cache in sensitive workflows * Disable actions cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, there is some potential for cache poisoning from other workflows. We shouldn't read from the cache in workflows with access to sensitive credentials to avoid this risk
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.