Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix playground snippets #31778

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

Amar3tto
Copy link
Contributor

@Amar3tto Amar3tto commented Jul 4, 2024

Fixes #31624


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Amar3tto Amar3tto marked this pull request as ready for review July 4, 2024 16:46
@Amar3tto
Copy link
Contributor Author

Amar3tto commented Jul 4, 2024

R: @tvalentyn

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@tvalentyn
Copy link
Contributor

tvalentyn commented Jul 4, 2024

LGTM, Thank you! Do you have any ideas about how we can find if any other examples are still broken in an automated way? or better in a test suite? Feel free to chime in on the issue.

@tvalentyn tvalentyn merged commit 0c89a0e into apache:master Jul 4, 2024
5 checks passed
@Amar3tto
Copy link
Contributor Author

Amar3tto commented Jul 4, 2024

LGTM, Thank you! Do you have any ideas about how we can find if any other examples are still broken in an automated way? or better in a test suite? Feel free to chime in on the issue.

I'll think how to do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Some Beam playground code snippets fail to load.
2 participants