Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support class executes the Prism binary #31795

Merged

Conversation

damondouglas
Copy link
Contributor

@damondouglas damondouglas commented Jul 7, 2024

This PR closes #31792 via a support class for executing the Prism binary.

cc: @lostluck


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damondouglas damondouglas changed the title A Java support class executes the Prism binary DRAFT A Java support class executes the Prism binary Jul 7, 2024
@damondouglas damondouglas force-pushed the prism-java-runner-wrapper-executor branch from 9e383b6 to 0f34d52 Compare July 8, 2024 18:02
@github-actions github-actions bot removed the java label Jul 8, 2024
@damondouglas damondouglas changed the title DRAFT A Java support class executes the Prism binary A Java support class executes the Prism binary Jul 8, 2024
@damondouglas damondouglas marked this pull request as ready for review July 8, 2024 18:29
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.20%. Comparing base (c08afea) to head (0f34d52).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #31795   +/-   ##
=========================================
  Coverage     71.20%   71.20%           
  Complexity     3020     3020           
=========================================
  Files          1058     1058           
  Lines        134159   134159           
  Branches       3257     3257           
=========================================
  Hits          95534    95534           
  Misses        35489    35489           
  Partials       3136     3136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damondouglas damondouglas changed the title A Java support class executes the Prism binary Support class executes the Prism binary Jul 8, 2024
@damondouglas damondouglas requested a review from Abacn July 9, 2024 15:36
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@damondouglas damondouglas merged commit 8153867 into apache:master Jul 9, 2024
15 checks passed
acrites pushed a commit to acrites/beam that referenced this pull request Jul 17, 2024
* Stage PrismRunner implementation and dependencies

* A Java support class executes the Prism binary

* Sync with head

* Remove pid
@damondouglas damondouglas deleted the prism-java-runner-wrapper-executor branch September 25, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task][Prism]: A Java support class executes the Prism binary
2 participants