Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --impersonate_service_account whenever PipelineOptions are serialized #32031

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

tvalentyn
Copy link
Contributor

fixes: #32030 - see the issue description for context.

Some IOs capture pipeline options and inadvertently pass them to Dataflow runner:

https://github.com/apache/beam/blob/release-2.56.0/sdks/python/apache_beam/io/gcp/bigquery.py#L723
https://github.com/apache/beam/blob/release-2.56.0/sdks/python/apache_beam/io/gcp/bigquery.py#L1148

Given that more IOs might do this in the future, this PR adds a custom serialization logic to filter out the impersonate_service_account option whenever we serialize pipeline options, similarly to how we filter it out whenever we convert pipeline options into a proto:

options_dict.pop('impersonate_service_account', None)


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @shunping for label python.
R: @kennknowles for label website.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn
Copy link
Contributor Author

R; @stephenmw

@stephenmw
Copy link

LGTM

Thanks!

@tvalentyn tvalentyn merged commit 2824944 into apache:master Jul 31, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants