[#31992][prism] Send side inputs for all SDF phases. #32042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
reeba212
pushed a commit
to reeba212/beam
that referenced
this pull request
Dec 4, 2024
) * [apache#31992] Send side inputs for all SDF phases. * delint. --------- Co-authored-by: lostluck <13907733+lostluck@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java SDK at the very least examines the ParDoPayload and expects side inputs across all SDF component transforms if the original one does.
Prior to this PR, Prism wasn't properly doing graph analysis for these components, so side inputs were being missed.
Initially the side input was only being provided to ProcessSizedElementsAndRestrictions, but this was causing the Java SDK to hang.
An attempt at rewriting the ParDoPayload and dropping the side inputs in the other transforms was made, but ultimately failed, since it looked like further stages in the execution relied on other information to detect a side input, or did actually need the side input. It wasn't worth the additional time to investigate further at this stage.
Minor comment, and debug logging adjustments for readability.
This change allows the 6 Java tests that validate side inputs used with SDFs to pass.
Fixes #31992
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.